Dump help/error fixes #3527
Merged
Dump help/error fixes #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
- Coverage 86.10% 86.07% -0.03%
==========================================
Files 330 330
Lines 38646 38646
==========================================
- Hits 33276 33266 -10
- Misses 3830 3839 +9
- Partials 1540 1541 +1 ☔ View full report in Codecov by Sentry. |
| @@ -100,7 +100,7 @@ func NewCommands() []*cli.Command { | |||
| Subcommands: []*cli.Command{ | |||
| { | |||
| Name: "dump", | |||
| Usage: "Dump blocks (starting with block #1) to the file", | |||
There was a problem hiding this comment.
Why do you reference the issue in the commit header?
There was a problem hiding this comment.
Because it fits in there? Usually the problem is that your 60-80 symbols is not enough for it.
AliceInHunterland
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.