Fix null handling in manifest #3523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsValid() is used by both compiler and ContractManagement then. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3523 +/- ##
==========================================
- Coverage 86.10% 86.10% -0.01%
==========================================
Files 330 330
Lines 38646 38660 +14
==========================================
+ Hits 33276 33288 +12
- Misses 3830 3833 +3
+ Partials 1540 1539 -1 ☔ View full report in Codecov by Sentry. |
Refs. #3522. Signed-off-by: Roman Khimov <[email protected]>
Refs. #3522. The core problem is the same as for groups/features: we can't allow empty trusts when they're unmarshalled from JSON. But unlike others we can't easily differentiate missing any value with other cases because the default value for WildPermissionDescs is a valid thing. Adding an additional field makes it invalid and we can build around it. Other options are implementing custom UnmarshalJSON for Manifest (too much for this) or making Trusts a pointer (an option, but can fail in too many ways). Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-null-handling-in-manifest
branch
from
c993f2b to
b10af1e
Compare
|
The fix is confirmed for testnet up to 4372513. |
|
Mainnet is OK up to 5759367. |
|
NeoFS mainnet is OK up to 6080412. |
|
NeoFS testnet is OK up to 3967861. |
AliceInHunterland
approved these changes
Jul 29, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Aug 5, 2024
Starting from b10af1e (*WildPermissionDescs).Add method's call is not enough to construct a proper restricted permission descriptor, because Wildcard field should be set properly at the same time. Ref. #3523. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
reviewed
Aug 5, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Aug 5, 2024
Starting from b10af1e (*WildPermissionDescs).Add method's call is not enough to construct a proper restricted permission descriptor, because Wildcard field should be set properly at the same time. Ref. #3523. Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3522.