rpcsrv: improve witness verification error #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed to give user a hint about what's wrong with the witness during `calculatenetworkfee` RPC request processing. Signed-off-by: Anna Shaleva <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3508 +/- ##
==========================================
+ Coverage 86.12% 86.13% +0.01%
==========================================
Files 331 331
Lines 38568 38568
==========================================
+ Hits 33215 33220 +5
+ Misses 3822 3821 -1
+ Partials 1531 1527 -4 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
approved these changes
Jul 11, 2024
carpawell
approved these changes
Jul 11, 2024
AnnaShaleva
added
I3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed to give user a hint about what's wrong with the witness during
calculatenetworkfeeRPC request processing.