core: avoid extra call to GetNextBlockValidatorsInternal #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be sufficient to retrieve next block validators once per updateExtensibleWhitelist call and then reuse this value. `nextVals` copy intentionally omitted since the only change that smartcontract.CreateDefaultMultiSigRedeemScript performs over the `nextVals` list is sorting. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added
U4
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3500 +/- ##
==========================================
+ Coverage 86.11% 86.16% +0.05%
==========================================
Files 331 331
Lines 38556 38556
==========================================
+ Hits 33201 33221 +20
+ Misses 3825 3800 -25
- Partials 1530 1535 +5 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
approved these changes
Jul 4, 2024
roman-khimov
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be sufficient to retrieve next block validators once per updateExtensibleWhitelist call and then reuse this value.
nextValscopy intentionally omitted since the only change that smartcontract.CreateDefaultMultiSigRedeemScript performs over thenextValslist is sorting.