invoker: add Signers() API #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
added
I3
roman-khimov
force-pushed
the
actor-signers
branch
from
500dbb9
to
9469f8f
Compare
|
Maybe we also need |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3492 +/- ##
==========================================
- Coverage 86.19% 86.11% -0.08%
==========================================
Files 331 331
Lines 38494 38507 +13
==========================================
- Hits 33179 33162 -17
- Misses 3785 3814 +29
- Partials 1530 1531 +1 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Jun 21, 2024
Signers are very important for notary checks and keeping/passing an additional copy of them is very inconvenient. Exposing them from invoker makes them available in actors too. Signed-off-by: Roman Khimov <[email protected]>
Allow to retrieve the list easily. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
actor-signers
branch
from
53c49d0
to
cc3f528
Compare
AnnaShaleva
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signers are very important for notary checks and keeping/passing an additional copy of them is very inconvenient. Exposing them from invoker makes them available in actors too.