Extend getpeers RPC method to provide useragent and last known height #3481
Conversation
|
@AnnaShaleva @roman-khimov Removed |
EdgeDLT
changed the title
|
Re-pushed most recent commit with sign-off because I forgot :) |
There was a problem hiding this comment.
Please, add neorpc: prefix to the commit message. Ref. https://github.com/nspcc-dev/.github/blob/master/git.md#commit-messages.
|
@AnnaShaleva Thanks Anna, changes made. |
EdgeDLT
force-pushed
the
getPeerHeights
branch
2 times, most recently
from
54c91d9
to
84808b8
Compare
|
@AnnaShaleva Think I got there eventually. Sorry for the trouble, I do very much appreciate the chance to practice a little :) |
|
DCO check is failing, but it's just too strict. I think we may skip it for this commit since it has a valid sign-off note: |
|
@EdgeDLT, could you please fix the latest comments? There's not much left, and then we can merge. |
Signed-off-by: edgedlt <[email protected]>
|
@AnnaShaleva Pushed the changes. |
|
@EdgeDLT, could you please fix the tests? It can be checked with |
|
@AnnaShaleva Sorry for the oversight, fixed! |
Signed-off-by: edgedlt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3481 +/- ##
==========================================
- Coverage 86.19% 86.12% -0.07%
==========================================
Files 331 331
Lines 38482 38541 +59
==========================================
+ Hits 33168 33193 +25
- Misses 3782 3819 +37
+ Partials 1532 1529 -3 ☔ View full report in Codecov by Sentry. |
Close #3480
I have
OldPeerHeightbecause I followedpeers.goas an example, but I expect it may be pointless here. Please remove if so.