Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cloud events output #20

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Add support for cloud events output #20

merged 1 commit into from
Jan 14, 2022

Conversation

nsmith5
Copy link
Owner

@nsmith5 nsmith5 commented Jan 12, 2022

Adds basic support for cloud event output. My understanding is a little superficial on this subject so looking for guidance on if this implementation is reasonable or has any limitations before merging

Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some nits on formatting of the cloudevents fields.

@nsmith5 nsmith5 force-pushed the outputs/cloudevents branch from 54e1a73 to cddaa5c Compare January 13, 2022 23:18
@nsmith5 nsmith5 merged commit 3ca8a8a into main Jan 14, 2022
@nsmith5 nsmith5 deleted the outputs/cloudevents branch January 14, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants