Rsync folders by Vagrant core code

[mkuzmin]

Vagrant 1.5 introduced a common logic for folder synchronization for all plugins (Rsync Synced Folders).

RSync-related code is now moved into Vagrant core, and maintained by Mitchell directly.
In vSphere plugin we need to get new bugfixes, for example hashicorp/vagrant#3804.

So duplicated and outdated Rsync-related code is removed, and inherited from Vagrant core.

Additionally I raise a requirement for minimal compatible Vagrant version to 1.5.

[flamingbear]

So I was able to build the plugin forcing a v1.5.0 and (v1.5.2), and install it into vagrant 1.5.2, but I get an internal error when I try to bring up a machine. Not sure where to look next.

vagrant --verbose up development
Bringing machine 'development' up with 'vsphere' provider...
==> development: Calling vSphere CloneVM with the following settings:
==> development:  -- Template VM: Linux/SCM/dev/ubuntu-12-LTS-dev
==> development:  -- Name: savoie-default-test-development-20140520123842
==> development: Waiting for SSH to become available...
==> development: New virtual machine successfully cloned and started
No host IP was given to the Vagrant core NFS helper. This is
an internal error that should be reported as a bug.
No error message

[mkuzmin]

I have Windows on my host system, so that's not so easy to test NFS-related issues.
I'll try to setup the environment.
Can you share your Vagrantfile please? I'm interested in config.vm.network and config.vm.synced_folder settings.

[mkuzmin]

Matt,
I need to clarify which exactly issue I need to fix. Did NFS folder sharing work in previous versions of the plugin?
Did I break something that worked before, or implemented a new feature incompletely?

[flamingbear]

Hey Michael,

I only build your gem and ran my standard machine up. I haven't had a
chance to look at this and I'm headed to the airport for vacation. Sorry
this will have to sit for a few days. I'm back early next week.

Cheers,
Matt

On Thu, May 22, 2014 at 9:41 AM, Michael Kuzmin [email protected]:

Matt,
I need to clarify which exactly issue I need to fix. Did NFS folder
sharing work in previous versions of the plugin?
Did I break something that worked before, or implemented a new feature
incompletely?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/66#issuecomment-43905363
.

[mkuzmin]

I've tested this on Mac OS host.
It seems NFS sync never worked before. A previous version of the plugin accepts a parameter
config.vm.synced_folder ".", "/vagrant", type: "nfs"
but NFS type is just ignored: synchronization is performed by RSync. With my changes NFS sync starts to fail.

It looks like this issue is out of scope of my pull request, but I've reproduced your error, and going to fix it.

[flamingbear]

Had to guess at a spec that was failing, but I don't know why it didn't fail without your changes. Happy to hear a suggestion if it's wrong.

Thanks.
Matt

[mkuzmin]

As I said, my PR implements RSync, but supporting NFS requires additional code.
This task is a bit harder than I originally thought, and I have no quick solution for it yet, sorry.