Refactor image builds #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces multi-stage image builds where it uses the upstream Golang image to build the project and then places it in an empty, scratch container to run it inside. This increases the security of the container significantly due to the fact that you don't have an operating system alongside it that you need to keep up to date. It also drives the size of the image down. This does introduce a small behaviour change in that you must manually setup your arguments and you no longer automatically have the configuration file auto-detected, but it's probably better for users to explicitly configure things rather than have it implicitly happen.
moolex
added a commit
to uuland/mikrotik-exporter
that referenced
this pull request
Apr 30, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces multi-stage image builds where it uses
the upstream Golang image to build the project and then places
it in an empty, scratch container to run it inside.
This increases the security of the container significantly due
to the fact that you don't have an operating system alongside
it that you need to keep up to date. It also drives the size
of the image down.
This does introduce a small behaviour change in that you must
manually setup your arguments and you no longer automatically
have the configuration file auto-detected, but it's probably
better for users to explicitly configure things rather than
have it implicitly happen.