Skip to content

feat(alerts): add support for new alerts #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2025
Merged

feat(alerts): add support for new alerts #136

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5147b6a
feat(alerts): add support for new alerts
arnavbhattacharya-NS1 Aug 8, 2025
c39a3a7
update client version
arnavbhattacharya-NS1 Aug 19, 2025
8f1e8da
Merge branch 'master' into feature/new-alerts
arnavbhattacharya-NS1 Aug 28, 2025
083db2f
fix linting
arnavbhattacharya-NS1 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.25.0 (August 20th, 2025)

ENHANCEMENTS:
* Adds support for new Alerts

## 0.24.0 (March 20th, 2025)

ENHANCEMENTS:
Expand Down
2 changes: 1 addition & 1 deletion ns1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#
from .config import Config

version = "0.24.0"
version = "0.25.0"


class NS1:
Expand Down
18 changes: 18 additions & 0 deletions tests/unit/test_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,24 @@ def test_rest_alert_list(alerts_config):
"data": {"min": 20, "max": 80},
},
),
(
"sso_alert",
"account",
"saml_certificate_expired",
"../alerting/v1/alerts",
{
"notifier_list_ids": ["6707da567cd4f300012cd7e4"],
},
),
(
"redirect_alert",
"redirects",
"certificate_renewal_failed",
"../alerting/v1/alerts",
{
"notifier_list_ids": ["6707da567cd4f300012cd7e4"],
},
),
],
)
def test_rest_alert_create(
Expand Down