Use per-mock mutexes in MockStore #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes mocks no longer panic, while making sure that calling individual mocked methods does not lock the entire mock. For convenience, the mutex is moved inside MockStore. Fixes nrxus#35. Signed-off-by: Igor Kotrasinski <[email protected]>
Wesmania
force-pushed
the
fix-mutex-panic
branch
from
ff8e999 to
3f27234
Compare
|
Ah thank you so much! This totally works! I had forgotten that I had implemented an "Exhausted" state to the mocks so they didn't get "consumed" anymore, it is always just by I will be merging this soon, I just want to make sure I fully grok it first (: |
|
I did some minor cosmetic tweaks to the tests, mostly for my own benefit for readability later (: Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes mocks no longer panic, while making sure that calling
individual mocked methods does not lock the entire mock. For
convenience, the mutex is moved inside MockStore.
Fixes #35.
Signed-off-by: Igor Kotrasinski [email protected]