Improve errors #23
Merged
Improve errors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All macro validations now return spanned darling::Error instances. This produces compile-time errors in the right places in input source code. Largely fixes nrxus#7, though unwrap() calls can still cause the macro to fail.
|
oh wow, thanks a lot for this, it looks great! As long as all the current tests pass I am happy with this without adding tests that verify the compiler error messages. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All macro validations now return spanned darling::Error instances.
This produces compile-time errors in the right places in input source code.
Largely fixes #7, though unwrap() calls can still cause the macro to fail.
PR Notes
arbitrary_self.rs, but those changes weren't committed. It's possible to do compile-error tests for proc-macro crates, but it's not easy.SelfTypegot some new methods to reduce boilerplate in other files.