Skip to content

readOne testing helper#4

Merged
vsavkin merged 2 commits into
nrwl:masterfrom
AustinMatherne:readOne
Sep 1, 2017
Merged

readOne testing helper#4
vsavkin merged 2 commits into
nrwl:masterfrom
AustinMatherne:readOne

Conversation

@AustinMatherne

@AustinMatherne AustinMatherne commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

I've found this little guy helpful for testing indefinite observables. Figured it might be useful for others.

@vsavkin

vsavkin commented Aug 31, 2017

Copy link
Copy Markdown
Member

Could you rename to readFirsts, so it matches the RxJS operator?

@AustinMatherne

Copy link
Copy Markdown
Contributor Author

Sure, that makes more sense. It's renamed.

@vsavkin vsavkin merged commit 0186fb4 into nrwl:master Sep 1, 2017
@vsavkin

vsavkin commented Sep 1, 2017

Copy link
Copy Markdown
Member

Merged! Thank you!

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants