Conversation
## Current Behavior The webinar banner has a hardcoded dark background (`bg-zinc-950`) with white text, making the close button barely visible in light mode since Starlight's global styles can override inherited text colors. ## Expected Behavior The banner adapts to the current theme: light mode shows a white background with dark text and a dark CTA button (matching the Framer marketing site), while dark mode retains the existing dark background with white text and pink CTA. ## Related Issue(s) Fixes DOC-457
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 514567e
☁️ Nx Cloud last updated this comment at |
barbados-clemens
approved these changes
Mar 26, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 26, 2026
…35029) ## Current Behavior The webinar banner has a hardcoded dark background (`bg-zinc-950`) with white text in both light and dark mode. This makes the close button barely visible in light mode since Starlight's global styles override inherited text colors. The banner design also differs noticeably from the Framer marketing site, which uses a light background in light mode. ## Expected Behavior The banner adapts to the current theme: - **Light mode**: White background, subtle border, dark text, dark CTA button — matching the Framer marketing site design - **Dark mode**: Retains the existing dark background with white text and pink CTA button All interactive elements (close button, CTA buttons) have proper contrast in both modes. Dark: <img width="759" height="499" alt="image" src="https://github.com/user-attachments/assets/684113e8-cc48-43df-b17d-431ae8c864fc" /> Light: <img width="635" height="318" alt="image" src="https://github.com/user-attachments/assets/9ed514b7-dfe9-45c6-91d7-158434aa6cdc" /> ## Related Issue(s) Fixes DOC-457 (cherry picked from commit dd376c2)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The webinar banner has a hardcoded dark background (
bg-zinc-950) with white text in both light and dark mode. This makes the close button barely visible in light mode since Starlight's global styles override inherited text colors. The banner design also differs noticeably from the Framer marketing site, which uses a light background in light mode.Expected Behavior
The banner adapts to the current theme:
All interactive elements (close button, CTA buttons) have proper contrast in both modes.
Dark:
Light:
Related Issue(s)
Fixes DOC-457