fix(vitest): resolve addPlugin default in init generator#34990
Merged
Conversation
The init generator had a wrapper function that hardcoded addPlugin: false, preventing the plugin from being added when running nx add @nx/vitest. Merged the two functions so the ??= default logic runs correctly.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit d4cc80d
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Mar 24, 2026
FrozenPandaz
added a commit
that referenced
this pull request
Mar 26, 2026
## Current Behavior Running `nx add @nx/vitest` does not register the `@nx/vitest` plugin in `nx.json`. The init generator had a wrapper function (`initGenerator`) that hardcoded `addPlugin: false` before spreading the user-provided schema. Since `nx add` calls the generator via CLI without passing `addPlugin`, the value stayed `false` — and the `??=` default logic in `initGeneratorInternal` never fired because `false` is not nullish. ## Expected Behavior Running `nx add @nx/vitest` should register the `@nx/vitest` plugin in `nx.json`, matching the behavior of other plugins like `@nx/jest`, `@nx/vite`, and `@nx/playwright`. ## Related Issue(s) <!-- No existing issue tracked for this --> ## Changes - Merged `initGenerator` and `initGeneratorInternal` into a single `initGenerator` function that uses the `??=` default logic directly - Added unit tests for the init generator covering plugin registration defaults, `NX_ADD_PLUGINS` env var, `addPlugin: true` vs `false` behavior, package.json handling, and namedInputs (cherry picked from commit 7da0798)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx add @nx/vitestdoes not register the@nx/vitestplugin innx.json. The init generator had a wrapper function (initGenerator) that hardcodedaddPlugin: falsebefore spreading the user-provided schema. Sincenx addcalls the generator via CLI without passingaddPlugin, the value stayedfalse— and the??=default logic ininitGeneratorInternalnever fired becausefalseis not nullish.Expected Behavior
Running
nx add @nx/vitestshould register the@nx/vitestplugin innx.json, matching the behavior of other plugins like@nx/jest,@nx/vite, and@nx/playwright.Related Issue(s)
Changes
initGeneratorandinitGeneratorInternalinto a singleinitGeneratorfunction that uses the??=default logic directlyNX_ADD_PLUGINSenv var,addPlugin: truevsfalsebehavior, package.json handling, and namedInputs