Skip to content

fix(angular): update duplicate migration keys#34961

Merged
leosvelperez merged 1 commit into
nrwl:masterfrom
JackWBaker:fix/angular-migration-keys
Mar 23, 2026
Merged

fix(angular): update duplicate migration keys#34961
leosvelperez merged 1 commit into
nrwl:masterfrom
JackWBaker:fix/angular-migration-keys

Conversation

@JackWBaker
Copy link
Copy Markdown
Contributor

Fix duplicate migrations keys as only the last migration was getting picked up.

Current Behavior

When running nx migrate only the module federation migration is picked up and not updating the core angular packages.

Expected Behavior

Both migrations should be added to migrations.json.

Fix duplicate migrations keys as only the last migration was getting
picked up.
@JackWBaker JackWBaker requested a review from a team as a code owner March 23, 2026 10:20
@JackWBaker JackWBaker requested a review from AgentEnder March 23, 2026 10:20
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 23, 2026

Deploy Preview for nx-docs canceled.

Name Link
🔨 Latest commit 942c317
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69c1140517e3990008885d0b

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 23, 2026

Deploy Preview for nx-dev canceled.

Name Link
🔨 Latest commit 942c317
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69c11405e3c595000838fd2f

Copy link
Copy Markdown
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leosvelperez leosvelperez enabled auto-merge (squash) March 23, 2026 11:53
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 23, 2026

View your CI Pipeline Execution ↗ for commit 942c317

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 23s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 6s View ↗
nx-cloud record -- pnpm nx conformance:check ✅ Succeeded 8s View ↗
nx build workspace-plugin ✅ Succeeded 1m 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-23 12:29:30 UTC

@leosvelperez leosvelperez merged commit 0e1f64d into nrwl:master Mar 23, 2026
16 of 17 checks passed
FrozenPandaz pushed a commit that referenced this pull request Mar 26, 2026
Fix duplicate migrations keys as only the last migration was getting
picked up.

## Current Behavior
When running nx migrate only the module federation migration is picked
up and not updating the core angular packages.

## Expected Behavior
Both migrations should be added to migrations.json.

(cherry picked from commit 0e1f64d)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants