fix(core): handle owners and conformance project refs on move/remove by barbados-clemens · Pull Request #34815 · nrwl/nx

barbados-clemens · 2026-03-13T15:14:40Z

Current Behavior

When removing or moving a project in an Nx workspace, the owners and conformance sections in nx.json are not updated. This leaves stale project references in:

conformance.rules[].projects (both plain strings and { matcher } objects)
owners.patterns[].projects (top-level and section-level for GitLab)

Expected Behavior

On project removal: Strip the removed project from all conformance rules and owners patterns. Remove entries that become empty after cleanup (rules with no projects, patterns with no projects).
On project move/rename: Rename all references to the old project name with the new name in conformance rules and owners patterns (including section-level patterns for GitLab-style CODEOWNERS).
Schema: Add owners configuration schema to nx-schema.json for validation and IDE support, including sections (GitLab CODEOWNERS).

Related Issue(s)

🤖 Generated with Claude Code

netlify · 2026-03-13T15:14:47Z

✅ Deploy Preview for nx-dev ready!

Name	Link
🔨 Latest commit	`3518626`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-dev/deploys/69c2f686df10b30008eaf1da
😎 Deploy Preview	https://deploy-preview-34815--nx-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-03-13T15:14:48Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`3518626`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69c2f6860671af000806c3c7
😎 Deploy Preview	https://deploy-preview-34815--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2026-03-13T15:15:16Z

View your CI Pipeline Execution ↗ for commit 3518626

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	1h 6m 18s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	9s	View ↗
`nx-cloud record -- pnpm nx conformance:check`	✅ Succeeded	7s	View ↗
`nx build workspace-plugin`	✅ Succeeded	45s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-24 22:06:31 UTC

barbados-clemens · 2026-03-17T14:45:12Z

      "required": ["rules"],
      "additionalProperties": false
+    },
+    "owners": {


add missing owners schema definition

barbados-clemens · 2026-03-17T14:46:04Z

+  // Remove project from conformance rules
+  if (removeProjectFromConformanceRules(nxJson, schema.projectName)) {
+    nxJsonChanged = true;
+  }
+
+  // Remove project from owners patterns
+  if (removeProjectFromOwnersPatterns(nxJson, schema.projectName)) {
+    nxJsonChanged = true;
+  }


make sure to remove projects referenced in conformance & owners configs

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

_{🎓 Learn more about Self-Healing CI on nx.dev}

When removing a project, also strip exact project name matches from `conformance.rules[].projects` and `owners.patterns[].projects` in nx.json so stale references don't linger. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add the owners configuration object to nx-schema.json matching the docs (format, outputPath, patterns, GitLab sections). Also update the remove generator to filter project refs from section-level patterns and handle the `owners: true` shorthand. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

When removing a project clears all projects from a conformance rule or owners pattern, remove the entire entry rather than leaving an empty projects array. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com>

…plice Replace nested filter callbacks with a reverse for-loop that splices empty entries in place, making the control flow easier to follow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…34815) ## Current Behavior When removing or moving a project in an Nx workspace, the `owners` and `conformance` sections in `nx.json` are not updated. This leaves stale project references in: - `conformance.rules[].projects` (both plain strings and `{ matcher }` objects) - `owners.patterns[].projects` (top-level and section-level for GitLab) ## Expected Behavior - **On project removal**: Strip the removed project from all conformance rules and owners patterns. Remove entries that become empty after cleanup (rules with no projects, patterns with no projects). - **On project move/rename**: Rename all references to the old project name with the new name in conformance rules and owners patterns (including section-level patterns for GitLab-style CODEOWNERS). - **Schema**: Add `owners` configuration schema to `nx-schema.json` for validation and IDE support, including sections (GitLab CODEOWNERS). ## Related Issue(s)  🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com> (cherry picked from commit f6692fc)

github-actions · 2026-03-30T00:19:04Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from ac82355 to 028acf8 Compare March 13, 2026 15:20

This comment was marked as outdated.

Sign in to view

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from 1671b1a to b751692 Compare March 16, 2026 20:49

barbados-clemens changed the title ~~fix(workspace): clean up owners and conformance project refs on remove~~ fix(core): clean up owners and conformance project refs on remove Mar 16, 2026

barbados-clemens self-assigned this Mar 16, 2026

This comment was marked as outdated.

Sign in to view

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from 37fa17a to b1ef800 Compare March 17, 2026 14:57

barbados-clemens commented Mar 17, 2026

View reviewed changes

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from b1ef800 to b057580 Compare March 23, 2026 15:46

This comment was marked as outdated.

Sign in to view

barbados-clemens changed the title ~~fix(core): clean up owners and conformance project refs on remove~~ feat(workspace): handle owners and conformance project refs on move/remove Mar 23, 2026

barbados-clemens marked this pull request as ready for review March 23, 2026 18:24

barbados-clemens requested a review from a team as a code owner March 23, 2026 18:24

barbados-clemens requested a review from leosvelperez March 23, 2026 18:24

barbados-clemens added the scope: core core nx functionality label Mar 23, 2026

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from 419ff09 to e084e93 Compare March 23, 2026 21:10

This comment was marked as outdated.

Sign in to view

nx-cloud Bot reviewed Mar 23, 2026

View reviewed changes

leosvelperez approved these changes Mar 24, 2026

View reviewed changes

barbados-clemens changed the title ~~feat(workspace): handle owners and conformance project refs on move/remove~~ feat(core): handle owners and conformance project refs on move/remove Mar 24, 2026

barbados-clemens changed the title ~~feat(core): handle owners and conformance project refs on move/remove~~ fix(core): handle owners and conformance project refs on move/remove Mar 24, 2026

barbados-clemens and others added 6 commits March 24, 2026 15:39

chore(workspace): format remove-project-references spec

431a2ee

Co-authored-by: barbados-clemens <barbados-clemens@users.noreply.github.com>

refactor(workspace): simplify project removal with reverse loop and s…

8f3ea94

…plice Replace nested filter callbacks with a reverse for-loop that splices empty entries in place, making the control flow easier to follow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat(workspace): rename owners and conformance refs on project move

3518626

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

barbados-clemens force-pushed the cu/remove-handles-owners-conformance-projects branch from fef6afc to 3518626 Compare March 24, 2026 20:39

barbados-clemens enabled auto-merge (squash) March 24, 2026 20:39

barbados-clemens merged commit f6692fc into master Mar 24, 2026
23 checks passed

barbados-clemens deleted the cu/remove-handles-owners-conformance-projects branch March 24, 2026 22:06

github-actions Bot locked as resolved and limited conversation to collaborators Mar 30, 2026

Conversation

barbados-clemens commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Related Issue(s)

Uh oh!

netlify Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-dev ready!

Uh oh!

netlify Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

nx-cloud Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

barbados-clemens Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

barbados-clemens Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud Bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

barbados-clemens commented Mar 13, 2026 •

edited

Loading

netlify Bot commented Mar 13, 2026 •

edited

Loading

netlify Bot commented Mar 13, 2026 •

edited

Loading

nx-cloud Bot commented Mar 13, 2026 •

edited

Loading