feat(nx-dev): add YouTube channel callout to courses page#34669
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for nx-dev failed. Why did it fail? →
|
|
View your CI Pipeline Execution ↗ for commit 4ea931d
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied automatically
These changes fix the sync:check failure by adding the missing TypeScript project reference from ui-video-courses to ui-icons. When the YoutubeIcon import was added to course-hero.tsx, it created a new project dependency that required a corresponding tsconfig reference for proper build ordering and type checking.
Tip
✅ We verified this fix by re-running nx-cloud record -- nx sync:check.
Suggested Fix changes
diff --git a/nx-dev/ui-video-courses/tsconfig.lib.json b/nx-dev/ui-video-courses/tsconfig.lib.json
index 522f164cbeb..c86125d40bf 100644
--- a/nx-dev/ui-video-courses/tsconfig.lib.json
+++ b/nx-dev/ui-video-courses/tsconfig.lib.json
@@ -23,6 +23,9 @@
],
"include": ["src/**/*.js", "src/**/*.jsx", "src/**/*.ts", "src/**/*.tsx"],
"references": [
+ {
+ "path": "../ui-icons/tsconfig.lib.json"
+ },
{
"path": "../ui-common/tsconfig.lib.json"
},
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: juristr <juristr@users.noreply.github.com>
The `@nx/next:build` executor generates a standalone `package.json` at `outputPath`, which clobbers source files when building in-place and breaks package resolution when building to a separate directory. Switch to using the inferred `next:build` target from `@nx/next/plugin` which runs `next build` directly in the project directory. The `build` target now runs `next build` + sitemap generation as sequential commands in a single target to avoid Nx output management cleaning `.next/` between dependent tasks. Also fixes missing `@nx/nx-dev-ui-icons` dependency in `ui-video-courses` introduced by #34669. Fixes DOC-418
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
Current Behavior
The courses page has a hero section with title and subtitle but no mention of the YouTube channel for one-off educational videos.
Expected Behavior
A subtle callout link with a YouTube icon appears below the hero subtitle, directing users to the Nx YouTube channel for one-off educational videos.
Related Issue(s)
N/A