Skip to content

fix(vitest): respect reporters from target options in vitest executor #34663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leosvelperez merged 1 commit into from
Mar 2, 2026
Merged

fix(vitest): respect reporters from target options in vitest executor #34663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/vitest/src/executors/test/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ export async function getOptions(
runMode: _runMode,
reportsDirectory,
coverage,
reporter,
reporters,
// parseCLI artifacts
'--': _dashdash,
color: _color,
Expand All @@ -95,14 +97,23 @@ export async function getOptions(
// but leaving it here in case someone did not migrate correctly
root: resolved?.config?.root ?? root,
config: viteConfigPath,
// Pass reporters from config so NxReporter can be merged without losing config reporters
// Safe: CLI options override (not merge with) config reporters, so no duplication
reporters: resolved?.config?.['test']?.reporters,
// Vitest's resolveConfig processes reporters in two steps:
// 1. options.reporters (plural) sets resolved.reporters
// 2. resolved.reporter (singular, from config) overwrites resolved.reporters
// Setting reporter to [] prevents config's reporter from overriding NxReporter
// (which is pushed onto reporters in vitest.impl.ts).
reporter: [],
reporters:
reporter ??
reporters ??
// reporter (singular) has higher priority in vitest but is not declared in InlineConfig
(resolved?.config?.['test'] as Record<string, any>)?.reporter ??
resolved?.config?.['test']?.reporters,
coverage: {
...(coverage ?? {}),
...(reportsDirectory && { reportsDirectory }),
},
};
} as Record<string, any>;
}

export function getOptionsAsArgv(obj: Record<string, any>): string[] {
Expand Down
Loading