Skip to content

fix(core): remove unused getTerminalOutput from BatchProcess #34604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrozenPandaz merged 2 commits into from
Feb 25, 2026
Merged

fix(core): remove unused getTerminalOutput from BatchProcess #34604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b84675
fix(core): remove unused getTerminalOutput from BatchProcess
leosvelperez Feb 24, 2026
8fb55d9
fix(core): remove unused getTerminalOutput from BatchProcess [Self-He…
nx-cloud[bot] Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/nx/src/tasks-runner/running-tasks/batch-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export class BatchProcess {
(task: string, result: TaskResult) => void
> = [];
private outputCallbacks: Array<(output: string) => void> = [];
private terminalOutputChunks: string[] = [];
private joinedTerminalOutput: string | undefined;

constructor(
private childProcess: ChildProcess,
Expand Down Expand Up @@ -59,7 +57,6 @@ export class BatchProcess {
if (this.childProcess.stdout) {
this.childProcess.stdout.on('data', (chunk) => {
const output = chunk.toString();
this.terminalOutputChunks.push(output);

// Maintain current terminal output behavior
process.stdout.write(chunk);
Expand All @@ -75,7 +72,6 @@ export class BatchProcess {
if (this.childProcess.stderr) {
this.childProcess.stderr.on('data', (chunk) => {
const output = chunk.toString();
this.terminalOutputChunks.push(output);

// Maintain current terminal output behavior
process.stderr.write(chunk);
Expand Down Expand Up @@ -134,9 +130,4 @@ export class BatchProcess {
this.childProcess.kill(signal);
}
}

getTerminalOutput(): string {
this.joinedTerminalOutput ??= this.terminalOutputChunks.join('');
return this.joinedTerminalOutput;
}
}
Loading