-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(nx-dev): update docs code blocks usage #32998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 277f438
☁️ Nx Cloud last updated this comment at |
909ba84 to
5de1806
Compare
5de1806 to
fe00ea6
Compare
fe00ea6 to
7aa112f
Compare
605813c to
7e299af
Compare
7e299af to
2c0a80f
Compare
2c0a80f to
89d2967
Compare
c891532 to
124e5df
Compare
c1a0d01 to
90a004b
Compare
90a004b to
b04f591
Compare
c4de134 to
518ee9e
Compare
by default code blocks will get text as the lang but be explict so I don't have to look at the warnings in the terminal output
by default code blocks will get text as the lang but be explict so I don't have to look at the warnings in the terminal output
the team has spoken! fixes DOC-259
518ee9e to
277f438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
by default code blocks will get text as the lang if not set or the lang is not supported but we should be so I don't have to look at the warnings in the terminal output 😅 also remove the frame=none since the team preferred to have the terminal frame Example of invalid codeblock messages  Also added conformance rule for validating image pages for public and src/assets/ directory examples of incorrect absolute path ref from "public" folder and incorrect absolute path:  fixes DOC-242 fixes DOC-259 (cherry picked from commit 4073537)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
by default code blocks will get text as the lang if not set or the lang is not supported
but we should be so I don't have to look at the warnings in the terminal output 😅
also remove the frame=none since the team preferred to have the terminal frame
Example of invalid codeblock messages

Also added conformance rule for validating image pages for public and src/assets/ directory
examples of incorrect absolute path ref from "public" folder and incorrect absolute path:
fixes DOC-242
fixes DOC-259