Skip to content

Conversation

@barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Oct 7, 2025

by default code blocks will get text as the lang if not set or the lang is not supported
but we should be so I don't have to look at the warnings in the terminal output 😅
also remove the frame=none since the team preferred to have the terminal frame

Example of invalid codeblock messages
wm_2025-10-15T11-26-05@2x

Also added conformance rule for validating image pages for public and src/assets/ directory

examples of incorrect absolute path ref from "public" folder and incorrect absolute path:

wm_2025-10-15T10-23-41@2x

fixes DOC-242
fixes DOC-259

@vercel
Copy link

vercel bot commented Oct 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Oct 23, 2025 5:04pm

@netlify
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 277f438
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68fa574f8b791b00082237f8
😎 Deploy Preview https://deploy-preview-32998--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Oct 7, 2025

View your CI Pipeline Execution ↗ for commit 277f438

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ❌ Failed 15m 49s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 3m 11s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 10s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-23 18:18:53 UTC

nx-cloud[bot]

This comment was marked as outdated.

@barbados-clemens barbados-clemens force-pushed the cu/fix-code-block-doc-warnings branch from 2c0a80f to 89d2967 Compare October 15, 2025 21:22
@barbados-clemens barbados-clemens marked this pull request as ready for review October 15, 2025 21:25
nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


🎓 To learn more about Self Healing CI, please visit nx.dev

@jaysoo jaysoo merged commit 4073537 into master Oct 23, 2025
18 of 21 checks passed
@jaysoo jaysoo deleted the cu/fix-code-block-doc-warnings branch October 23, 2025 20:22
FrozenPandaz pushed a commit that referenced this pull request Oct 27, 2025
by default code blocks will get text as the lang if not set or the lang
is not supported
but we should be so I don't have to look at the warnings in the terminal
output 😅
also remove the frame=none since the team preferred to have the terminal
frame

Example of invalid codeblock messages

![wm_2025-10-15T11-26-05@2x](https://github.com/user-attachments/assets/33161287-3fa3-4897-a5dd-0de3a47b37fe)

Also added conformance rule for validating image pages for public and
src/assets/ directory

examples of incorrect absolute path ref from "public" folder and
incorrect absolute path:

![wm_2025-10-15T10-23-41@2x](https://github.com/user-attachments/assets/354800a4-6628-4236-87d9-2590cb56fe54)

fixes DOC-242
fixes DOC-259

(cherry picked from commit 4073537)
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants