fix(core): detect vscode insiders as separate editor

[MaxKless]

Current Behavior

right now nx checks the installation state for vscode for both vscode & vscode insiders

Expected Behavior

They should be handled separately as they have separate sets of installed extensions.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
nx-dev	Ready	Preview	Sep 10, 2025 4:25pm

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ca6221c

Command	Status	Duration	Result
nx affected --targets=lint,test,build,e2e,e2e-c...	✅ Succeeded	6m 51s	View ↗
nx run-many -t check-imports check-commit check...	✅ Succeeded	2m 7s	View ↗
nx-cloud record -- nx-cloud conformance:check	✅ Succeeded	2s	View ↗
nx-cloud record -- nx sync:check	✅ Succeeded	6s	View ↗
nx-cloud record -- nx format:check	✅ Succeeded	6s	View ↗
nx documentation	✅ Succeeded	2m 55s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-09-11 09:00:41 UTC

[nx-cloud]

Nx Cloud is proposing a fix for your failed CI:

We've implemented a fallback mechanism for Playwright browser installation to handle apt package manager lock conflicts. When the installation with system dependencies (--with-deps) fails due to lock issues, the code now automatically retries without system dependencies, allowing the e2e tests to proceed successfully.

We verified this fix by re-running e2e-react:e2e-ci--src/react-rsbuild.test.ts.

Suggested Fix changes

diff --git a/e2e/utils/get-env-info.ts b/e2e/utils/get-env-info.ts
index 20173dd..6694a5d 100644
--- a/e2e/utils/get-env-info.ts
+++ b/e2e/utils/get-env-info.ts
@@ -196,6 +196,38 @@ export function ensurePlaywrightBrowsersInstallation() {
         .trim()} installed.`
     );
   } catch (error) {
+    // Check if the error is related to apt package manager lock
+    const errorMessage = error?.toString() || '';
+    if (
+      errorMessage.includes('Could not get lock') ||
+      errorMessage.includes('Unable to lock directory')
+    ) {
+      e2eConsoleLogger(
+        'System package lock detected, trying without system dependencies...'
+      );
+
+      try {
+        // Retry without --with-deps to avoid system package manager conflicts
+        execSync('npx playwright install', {
+          stdio: isVerbose() ? 'inherit' : 'pipe',
+          encoding: 'utf-8',
+          cwd: tmpProjPath(),
+        });
+
+        e2eConsoleLogger(
+          `Playwright browsers ${execSync('npx playwright --version')
+            .toString()
+            .trim()} installed without system dependencies.`
+        );
+        return;
+      } catch (retryError) {
+        e2eConsoleLogger(
+          'Failed to install Playwright browsers without system dependencies:',
+          retryError
+        );
+      }
+    }
+
     e2eConsoleLogger('Failed to install Playwright browsers:', error);
     throw error;
   }

❌ The fix was rejected.

View interactive diff and more actions ↗

_{⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.}

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.