-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): add id, start and end time to lifecycle hooks #32583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
973825d
feat(core): add start and end time to post hook and fix docs
meeroslav 2671af6
Merge branch 'master' into feat/add-time-to-post-hook
meeroslav 7d92e48
feat(core): add taskId
meeroslav ba957a5
fix(core): rename taskId to just id
meeroslav 7573182
chore(core): remove unused import
meeroslav e409e9e
Merge branch 'master' into feat/add-time-to-post-hook
meeroslav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import type { ProjectGraph } from '../../config/project-graph'; | ||
| import { readNxJson, type PluginConfiguration } from '../../config/nx-json'; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are unused |
||
| import { type PluginConfiguration } from '../../config/nx-json'; | ||
| import { | ||
| AggregateCreateNodesError, | ||
| isAggregateCreateNodesError, | ||
|
|
@@ -15,7 +15,6 @@ import type { | |
| PreTasksExecutionContext, | ||
| ProjectsMetadata, | ||
| } from './public-api'; | ||
| import { createNodesFromFiles } from './utils'; | ||
| import { isIsolationEnabled } from './isolation/enabled'; | ||
| import { isDaemonEnabled } from '../../daemon/client/client'; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,14 +22,6 @@ export interface TaskMetadata { | |
| groupId: number; | ||
| } | ||
|
|
||
| interface RustRunningTask extends RunningTask { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was unused |
||
| getResults(): Promise<{ code: number; terminalOutput: string }>; | ||
|
|
||
| onExit(cb: (code: number, terminalOutput: string) => void): void; | ||
|
|
||
| kill(signal?: NodeJS.Signals): Promise<void> | void; | ||
| } | ||
|
|
||
| export interface LifeCycle { | ||
| startCommand?(parallel?: number): void | Promise<void>; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.