feat(core): add NX_PROJECT_ROOT environment variable to runtime cache inputs #31428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit bb68655
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
added
the
priority: medium
AgentEnder
force-pushed
the
claude/issue-20949-20250602_200652
branch
from
33d1c49 to
48db687
Compare
FrozenPandaz
requested changes
Jul 17, 2025
| } | ||
| HashInstruction::Runtime(runtime) => { | ||
| // Extract project name from task_id (format: "project:target") | ||
| let project_name = task_id.split(':').next().unwrap_or(task_id); |
Collaborator
There was a problem hiding this comment.
This is not foolproof. Let's pass the name in.
AgentEnder
force-pushed
the
claude/issue-20949-20250602_200652
branch
from
48db687 to
7ea4133
Compare
… inputs Adds NX_PROJECT_ROOT environment variable to runtime cache input commands, allowing project-aware cache inputs for more granular caching strategies. - Extract project name from task_id during runtime hash instruction processing - Inject NX_PROJECT_ROOT environment variable with project root path - Maintain backwards compatibility with existing runtime cache inputs - Add comprehensive test coverage for the new functionality Co-Authored-By: AgentEnder <[email protected]>
AgentEnder
force-pushed
the
claude/issue-20949-20250602_200652
branch
from
7ea4133 to
5a717f7
Compare
AgentEnder
force-pushed
the
claude/issue-20949-20250602_200652
branch
from
505d4bc to
bb68655
Compare
FrozenPandaz
approved these changes
Sep 4, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NX_PROJECT_ROOT environment variable to runtime cache inputs
Current Behavior
Runtime cache input commands do not have access to project-specific context, making it impossible to create project-aware runtime inputs.
Expected Behavior
Runtime cache input commands can access
$NX_PROJECT_ROOTenvironment variable containing the project's root directory path.Related Issue(s)
Fixes #20949
Generated with Claude Code