feat(js): remove nx property from generated package.json files #29705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
from
7836fb2 to
8ae3480
Compare
|
View your CI Pipeline Execution ↗ for commit caa023d.
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
2 times, most recently
from
79c94ef to
59b78b0
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 21, 2025
…+ skip writing empty nx property to pacakge.json for non-root projects (#29707) This PR is a prerequisite to removing `nx` property from `package.json` files in the new TS setup. It fixes two issues: 1. We always write `nx` property in `package.json` even if it is empty. This should be done for root projects. 2. Adding an entry to `pnpm-workspace.yaml` is not picked up because `readProjectConfiguration` only reads the file from disk, not from virtual `Tree` This is the next PR to remove the property: #29705
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
19 times, most recently
from
28d2a6c to
bc2a0dd
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29705-bc2a0dd
To request a new release for this pull request, mention someone from the Nx team or the |
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
from
bc2a0dd to
f0047ae
Compare
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
from
f0047ae to
055af63
Compare
leosvelperez
approved these changes
Jan 23, 2025
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
from
055af63 to
2a402a9
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-29705-2a402a9
To request a new release for this pull request, mention someone from the Nx team or the |
jaysoo
force-pushed
the
feat/remove-nx-from-package-json
branch
from
1d54167 to
caa023d
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our generators to no longer generate with
nxinpackage.jsonby default. The only times it is needed is if you pass addtagsorimplicitDependenciesto the project config.This PR replaces our
projectTypechecks to use thegetProjectTypeutil from@nx/jsto prefer the project config, but otherwise will check for our conventions (e.g. usingexportsfor libs,tsconfig.lib.jsonvstsconfig.app.json).Impact
projectType,name, etc. in withproject.jsonorpackage.json(vianxproperty).nxproperty will no longer be there. Generators with logic that depend onprojectTypewill now check fortsconfig.lib.jsonandtsconfig.app.json(so all of our generators are covered). If none of those tsconfig files are found, then we checkpackage.json, since libraries are required to haveexportsto be consumed.