fix(testing): e2e config generators should prompt for missing serve data #29660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit d549af1.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jan 17, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 17, 2025
…ata (#29660) ## Current Behavior When running the `configuration` generator from `@nx/playwright` and `@nx/cypress` for existing appliactions - they currently generate a config that is likely to be invalid becaue there is not enough information to correctly assume the port, target and baseUrl for the application. This data is provided by the application generators that call the `configuration` generator - but that means that users running it manually must remember to pass the information via flags. ## Expected Behavior If the serve data is missing, prompt the user to input the correct information to ensure the config generation is as accurate as possible. (cherry picked from commit bc0566f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running the
configurationgenerator from@nx/playwrightand@nx/cypressfor existing appliactions - they currently generate a config that is likely to be invalid becaue there is not enough information to correctly assume the port, target and baseUrl for the application.This data is provided by the application generators that call the
configurationgenerator - but that means that users running it manually must remember to pass the information via flags.Expected Behavior
If the serve data is missing, prompt the user to input the correct information to ensure the config generation is as accurate as possible.