fix(react): setup mf env var as input for rspack #29584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c4c5597.
☁️ Nx Cloud last updated this comment at |
jaysoo
reviewed
Jan 10, 2025
| @@ -8,10 +8,11 @@ import { | |||
| import { addMfEnvToTargetDefaultInputs } from '../../utils/add-mf-env-to-inputs'; | |||
|
|
|||
| export default async function (tree: Tree) { | |||
| if (!hasModuleFederationProject(tree)) { | |||
| const bundler = hasModuleFederationProject(tree); | |||
There was a problem hiding this comment.
Should there be another migration for 20.4 for projects created after v18?
There was a problem hiding this comment.
jaysoo
approved these changes
Jan 10, 2025
jaysoo
pushed a commit
that referenced
this pull request
Jan 10, 2025
## Current Behavior The Module Federation `NxRuntimeLibraryControlPlugin` relies on an environment variable that is set during the build/serve process. This could potentially lead to issues with cache restoration. The impact should be minimal as the runtime control plugin should only be added to the module federation config when the env var is set. It should only be set by the `module-federation-dev-server` executor which is invoked during serve - a non-cacheable task already. ## Expected Behavior Ensure the env var is set as an input to ensure maximum accuracy with module federation builds via rspack executor
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
## Current Behavior The Module Federation `NxRuntimeLibraryControlPlugin` relies on an environment variable that is set during the build/serve process. This could potentially lead to issues with cache restoration. The impact should be minimal as the runtime control plugin should only be added to the module federation config when the env var is set. It should only be set by the `module-federation-dev-server` executor which is invoked during serve - a non-cacheable task already. ## Expected Behavior Ensure the env var is set as an input to ensure maximum accuracy with module federation builds via rspack executor (cherry picked from commit dbdb72a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The Module Federation
NxRuntimeLibraryControlPluginrelies on an environment variable that is set during the build/serve process.This could potentially lead to issues with cache restoration.
The impact should be minimal as the runtime control plugin should only be added to the module federation config when the env var is set.
It should only be set by the
module-federation-dev-serverexecutor which is invoked during serve - a non-cacheable task already.Expected Behavior
Ensure the env var is set as an input to ensure maximum accuracy with module federation builds via rspack executor