feat(testing): allow custom address for local registry #29050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c5d6bc2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
tinesoft
force-pushed
the
fix/jest-start-verdaccio
branch
from
55f9619 to
19338bc
Compare
tinesoft
added a commit
to tinesoft/nxrocks
that referenced
this pull request
Nov 24, 2024
Until nrwl/nx#29050 is merged and released
tinesoft
added a commit
to tinesoft/nxrocks
that referenced
this pull request
Nov 27, 2024
… starting the local registry Until nrwl/nx#29050 is merged and released
Closed
4 tasks
tinesoft
added a commit
to tinesoft/nxrocks
that referenced
this pull request
Dec 2, 2024
… starting the local registry Until nrwl/nx#29050 is merged and released
xiongemi
changed the title
xiongemi
changed the title
xiongemi
force-pushed
the
fix/jest-start-verdaccio
branch
from
ba68fa5 to
d94bc90
Compare
xiongemi
approved these changes
Dec 2, 2024
xiongemi
changed the title
xiongemi
force-pushed
the
fix/jest-start-verdaccio
branch
from
d94bc90 to
547dc7f
Compare
xiongemi
changed the title
tinesoft
force-pushed
the
fix/jest-start-verdaccio
branch
3 times, most recently
from
914f980 to
4b76394
Compare
tinesoft
added a commit
to tinesoft/nxrocks
that referenced
this pull request
Dec 4, 2024
… starting the local registry Until nrwl/nx#29050 is merged and released
tinesoft
force-pushed
the
fix/jest-start-verdaccio
branch
from
4b76394 to
c5d6bc2
Compare
jaysoo
approved these changes
Dec 10, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 10, 2024
… output<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The `startLocalRegistry()` always assumed that the local registry was started on `localhost` , which is not necessary the case, if for example user has set the `listenAddress` option in the underlying `verdaccio executor` or via the `verdaccio config file`https://github.com/nrwl/nx/blob/128778e7d1a8d7f2b078b2401d47270c0c15a2ce/packages/js/src/executors/verdaccio/verdaccio.impl.ts#L130 As a result the `startLocalregistry()`, will never return as, it is waiting forever to detect the local registry URL in the process output: https://github.com/nrwl/nx/blob/128778e7d1a8d7f2b078b2401d47270c0c15a2ce/packages/js/src/plugins/jest/start-local-registry.ts#L40 This customization of `verdaccio` listen address is something required, namely when running within a **devcontainer**. In that case, the address must be set to `0.0.0.0`, so that the registry can be accessed from `http://localhost:4873` from host machine. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Allow customizing the `listenAddress` when starting the local registry, via an additional option that can be provided when calling the method. It default value will be `localhost`. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28238 (cherry picked from commit cfb67cf)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… output
Current Behavior
The
startLocalRegistry()always assumed that the local registry was started onlocalhost, which is not necessary the case, if for example user has set thelistenAddressoption in the underlyingverdaccio executoror via theverdaccio config filenx/packages/js/src/executors/verdaccio/verdaccio.impl.ts
Line 130 in 128778e
As a result the
startLocalregistry(), will never return as, it is waiting forever to detect the local registry URL in the process output:nx/packages/js/src/plugins/jest/start-local-registry.ts
Line 40 in 128778e
This customization of
verdacciolisten address is something required, namely when running within a devcontainer. In that case, the address must be set to0.0.0.0, so that the registry can be accessed fromhttp://localhost:4873from host machine.Expected Behavior
Allow customizing the
listenAddresswhen starting the local registry, via an additional option that can be provided when calling the method. It default value will belocalhost.Related Issue(s)
Fixes #28238