feat(module-federation): move withModuleFederation for rspack to new package #29045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9aa7a16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
module-federation/rspack-with-mf
branch
from
0db7672
to
9aa7a16
Compare
ndcunningham
approved these changes
Nov 22, 2024
jaysoo
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
withModuleFederationhelper currently lives in the@nx/rspackpackage.With the goal of consolidating the module federation support into a single package, this introduces a divergence in where module-federation support lies
Expected Behavior
Move
withModuleFederationhelper for angular into the@nx/module-federationpackage, exposed via@nx/module-federation/rspack.Adds a migration to migrate existing projects to use the new package
Related Issue(s)
Fixes #