-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rspack): add convert-to-inferred generator #29012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8dfd5da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
rspack/convert-to-inferred
branch
from
November 20, 2024 19:08
78be793
to
0fef5d3
Compare
Coly010
force-pushed
the
rspack/convert-to-inferred
branch
from
November 20, 2024 20:44
0fef5d3
to
567e1fc
Compare
ndcunningham
requested changes
Nov 20, 2024
...ges/rspack/src/generators/convert-config-to-rspack-plugin/convert-config-to-rspack-plugin.ts
Show resolved
Hide resolved
ndcunningham
approved these changes
Nov 20, 2024
Coly010
force-pushed
the
rspack/convert-to-inferred
branch
from
November 20, 2024 21:32
567e1fc
to
91978c9
Compare
Coly010
force-pushed
the
rspack/convert-to-inferred
branch
from
November 20, 2024 21:35
91978c9
to
df42be8
Compare
jaysoo
approved these changes
Nov 20, 2024
Coly010
force-pushed
the
rspack/convert-to-inferred
branch
from
November 20, 2024 21:36
df42be8
to
8dfd5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our current rspack configs rely on executor usage.
But there is no automated method to convert the config to use inferred targets
Expected Behavior
Add convert-to-inferred generator
Related Issue(s)
Fixes #