fix(remix): remove tooling packages from generated package.json since they are installed in the root #29009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they are installed in the root
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c236f29. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
Nov 20, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 22, 2024
… they are installed in the root (#29009) The `eslint` version is causing errors like: ``` Error while loading rule '@typescript-eslint/no-unused-expressions': Cannot read properties of undefined (reading 'allowShortCircuit') ``` This is because we are installing both eslint 8 and 9 to the workspace, which are not compatible. We shouldn't need to add `eslint`, `typescript`, `vite` and other tooling to the app's package.json since they should following single version policy by default and be installed at the root. Note: This is only an issue when you enable workspaces. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 8f67441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eslintversion is causing errors like:This is because we are installing both eslint 8 and 9 to the workspace, which are not compatible. We shouldn't need to add
eslint,typescript,viteand other tooling to the app's package.json since they should following single version policy by default and be installed at the root.Note: This is only an issue when you enable workspaces.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #