feat(module-federation): consolidate module federation utils into module-federation package #28919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
a team,
jaysoo and
FrozenPandaz
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 60a83cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
…ule-federation package
…eep requires are needed
Coly010
force-pushed
the
module-federation/move-utils
branch
from
495da72
to
09239f2
Compare
Coly010
force-pushed
the
module-federation/move-utils
branch
from
462a72c
to
fadd817
Compare
leosvelperez
requested changes
Nov 15, 2024
packages/angular/src/migrations/update-20-2-0/migrate-mf-imports-to-new-package.ts
Outdated
Show resolved
Hide resolved
packages/react/src/migrations/update-20-2-0/migrate-mf-imports-to-new-package.ts
Outdated
Show resolved
Hide resolved
leosvelperez
approved these changes
Nov 15, 2024
Coly010
force-pushed
the
module-federation/move-utils
branch
from
524d0b1
to
39039ec
Compare
FrozenPandaz
approved these changes
Nov 15, 2024
ndcunningham
approved these changes
Nov 15, 2024
Coly010
force-pushed
the
module-federation/move-utils
branch
from
39039ec
to
60a83cc
Compare
jaysoo
approved these changes
Nov 18, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our current support for Module Federation relies on utilities that are spread and duplicated across the
@nx/webpackpackage and the@nx/rspackpackage.Expected Behavior
Now that we have a
@nx/module-federationpackage, dedupe the utils and consolidate them into a single packageTodo
@nx/module-federationand pointModuleFederationConfigexport to that package from webpack.config and rspack.config files