-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rspack): update executor to be in line with webpack #28913
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2d8a27c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
a002c96
to
94b5aed
Compare
94b5aed
to
2d8a27c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but there's a HMR issue when styles
are set. I don't know if related to this PR or not, but it might be worth solving it now as this is being worked on
This PR brings the rspack executor `@nx/rspack:rspack` inline with webpack. It also prepares the executor to be used with the soon to be implemented `NxRspackAppPlugin` so that we can support executor and inferred targets.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR brings the rspack executor
@nx/rspack:rspack
inline with webpack.It also prepares the executor to be used with the soon to be implemented
NxRspackAppPlugin
so that we can support executor and inferred targets.