Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): update executor to be in line with webpack #28913

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Nov 13, 2024

This PR brings the rspack executor @nx/rspack:rspack inline with webpack.

It also prepares the executor to be used with the soon to be implemented NxRspackAppPlugin so that we can support executor and inferred targets.

@ndcunningham ndcunningham self-assigned this Nov 13, 2024
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 13, 2024 10:29pm

@ndcunningham ndcunningham force-pushed the feat/rspack-executor-align-webpack branch 3 times, most recently from a002c96 to 94b5aed Compare November 13, 2024 21:05
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but there's a HMR issue when styles are set. I don't know if related to this PR or not, but it might be worth solving it now as this is being worked on

@Coly010 Coly010 merged commit da60c38 into master Nov 14, 2024
6 checks passed
@Coly010 Coly010 deleted the feat/rspack-executor-align-webpack branch November 14, 2024 18:31
nartc pushed a commit that referenced this pull request Nov 15, 2024
This PR brings the rspack executor `@nx/rspack:rspack` inline with
webpack.

It also prepares the executor to be used with the soon to be implemented
`NxRspackAppPlugin` so that we can support executor and inferred
targets.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants