feat(rspack): move logic for withNx to applyBaseConfig and bring in line with webpack #28825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3552126. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
rspack/with-nx
branch
2 times, most recently
from
a1e0dd5
to
3e7b809
Compare
ndcunningham
reviewed
Nov 8, 2024
Coly010
force-pushed
the
rspack/with-nx
branch
from
3e7b809
to
4cfff1d
Compare
Coly010
force-pushed
the
rspack/with-nx
branch
from
b227747
to
b5591f5
Compare
ndcunningham
approved these changes
Nov 12, 2024
Coly010
force-pushed
the
rspack/with-nx
branch
from
f74f840
to
e625cf1
Compare
Coly010
force-pushed
the
rspack/with-nx
branch
from
7907bdd
to
5fdfc29
Compare
Coly010
force-pushed
the
rspack/with-nx
branch
from
b515d96
to
b34c086
Compare
Coly010
force-pushed
the
rspack/with-nx
branch
from
b34c086
to
4d95a74
Compare
Coly010
force-pushed
the
rspack/with-nx
branch
from
4f462ca
to
926c6ba
Compare
jaysoo
reviewed
Nov 12, 2024
jaysoo
approved these changes
Nov 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
withNxfrom@nx/rspackis not reflective of what@nx/webpackdoes.Expected Behavior
Bring
withNxin line with@nx/webpackNotes