Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): update withReact plugin for parity with webpack plugin #28812

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 7:41pm

@ndcunningham ndcunningham force-pushed the feat/rspack-with-react branch 2 times, most recently from c4f179a to 3b33b0d Compare November 7, 2024 15:51
@ndcunningham ndcunningham marked this pull request as ready for review November 7, 2024 17:45
@ndcunningham ndcunningham requested a review from a team as a code owner November 7, 2024 17:45
@ndcunningham ndcunningham self-assigned this Nov 8, 2024
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a circular dep removal and this should be fine.

Has it been tested with Standard React app and with Module Federation?

packages/rspack/src/utils/with-react.ts Outdated Show resolved Hide resolved
packages/rspack/src/utils/lib/apply-react-config.ts Outdated Show resolved Hide resolved
@ndcunningham ndcunningham force-pushed the feat/rspack-with-react branch 2 times, most recently from ba71e74 to 410e86c Compare November 12, 2024 19:28
@Coly010 Coly010 merged commit cda7f26 into master Nov 12, 2024
6 checks passed
@Coly010 Coly010 deleted the feat/rspack-with-react branch November 12, 2024 20:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants