Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): move eslint-config-prettier to the end for proper override #28503

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

demonicattack
Copy link
Contributor

There is a conflict between ESLint and Prettier rules, which causes incorrect formatting behavior.

Reordering the config so that eslint-config-prettier is applied last ensures proper rule overrides and resolves conflicts with Prettier.

@demonicattack demonicattack requested a review from a team as a code owner October 17, 2024 19:22
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 19, 2024 7:36am

@demonicattack demonicattack changed the title fix(eslint): move eslint-config-prettier to the end for proper override fix(core): move eslint-config-prettier to the end for proper override Oct 17, 2024
@demonicattack demonicattack changed the title fix(core): move eslint-config-prettier to the end for proper override fix(linter): move eslint-config-prettier to the end for proper override Oct 18, 2024
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to contribute!

The change looks good to me. There's only a minor change suggested to the source code comments.

packages/eslint-plugin/src/flat-configs/javascript.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/src/flat-configs/typescript.ts Outdated Show resolved Hide resolved
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leosvelperez leosvelperez merged commit 25909b0 into nrwl:master Nov 19, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Nov 22, 2024
…de (#28503)

There is a conflict between ESLint and Prettier rules, which causes
incorrect formatting behavior.

Reordering the config so that `eslint-config-prettier` is applied last
ensures proper rule overrides and resolves conflicts with Prettier.

---------

Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
(cherry picked from commit 25909b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants