Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add flag when db is disabled for task history #28059

Merged

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner September 23, 2024 19:51
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:58pm

@xiongemi xiongemi force-pushed the feature/nxc-1049-stackblitz-is-connecting-to-sql-to-run-tasks branch from d7a2af2 to b97db41 Compare September 23, 2024 19:51
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise.

packages/nx/src/utils/task-history.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feature/nxc-1049-stackblitz-is-connecting-to-sql-to-run-tasks branch from b97db41 to 69c3c97 Compare September 23, 2024 20:29
@xiongemi xiongemi force-pushed the feature/nxc-1049-stackblitz-is-connecting-to-sql-to-run-tasks branch from 69c3c97 to 062a838 Compare September 23, 2024 21:55
@xiongemi xiongemi enabled auto-merge (squash) September 23, 2024 22:27
@xiongemi xiongemi merged commit 3e1a879 into master Sep 23, 2024
5 of 6 checks passed
@xiongemi xiongemi deleted the feature/nxc-1049-stackblitz-is-connecting-to-sql-to-run-tasks branch September 23, 2024 22:38
FrozenPandaz pushed a commit that referenced this pull request Sep 25, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 3e1a879)
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants