fix(linter): only depend on eslint v8

[FrozenPandaz]

Current Behavior

@nx/eslint is bringing in eslint v9 prematurely.

Expected Behavior

@nx/eslint should not bring in eslint v9 yet. Though, it does have support for having v9 installed at the workspace level.

Related Issue(s)

Fixes #25319

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	May 23, 2024 4:58pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f2e274e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=37f02f7e6b301975977dc2f7bdcb0fb4c2609317 --head=f2e274e1cf557ce32b2d48b06dcf2c56481685ba --parallel=1
• nx affected --targets=lint,test,build --base=37f02f7e6b301975977dc2f7bdcb0fb4c2609317 --head=f2e274e1cf557ce32b2d48b06dcf2c56481685ba --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=37f02f7e6b301975977dc2f7bdcb0fb4c2609317 --head=f2e274e1cf557ce32b2d48b06dcf2c56481685ba
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=37f02f7e6b301975977dc2f7bdcb0fb4c2609317 --head=f2e274e1cf557ce32b2d48b06dcf2c56481685ba

---

Sent with 💌 from NxCloud.

[robertIsaac]

Hi @FrozenPandaz
Isn't nx support eslint 9 in #24632
I'm confused now
Does nx support eslint 9 or not

[astroanu]

Does not fully support i guess

[JamesHenry]

@robertIsaac @astroanu Per the description on this PR, it should work fine to install eslint v9 at the root of your workspace if you want to.

This change just fixes the issue that Nx was briefly forcing eslint v9 upon users before they were ready. We are going to look into changing this dependency into a peer dependency in a follow up. It was originally done to keep yarn v1/classic happy I believe

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.