Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): handle case where tslib or @swc/helpers are missing from externalNodes #22523

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 26, 2024

This PR makes the findNpmDependencies function more resilient when a helper package is missing from externalNodes. If the workspace does not have tslib or @swc/helpers in externalNodes, it will not be included in a project's expected npm dependencies.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner March 26, 2024 20:34
@jaysoo jaysoo requested a review from mandarini March 26, 2024 20:34
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Mar 26, 2024 8:34pm

@FrozenPandaz FrozenPandaz merged commit 82dc703 into master Mar 26, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix_js_find_deps branch March 26, 2024 22:05
Copy link

github-actions bot commented Apr 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants