fix(react): fix builder options for storybook plugin

[puku0x]

Current Behavior

Nx + Next.js + SVGR + Storybook (storybook-addon-next) with Nx's SB plugin fails to handle assets because @nrwl/react/plugins/storybook does not pass target which is needed for @nrwl/webpack:webpack executor.

Expected Behavior

It should work with no build errors.

Related Issue(s)

Fixes #

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a453a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=ee1d0a649881edb418803f281691b1fbc879e1ec --head=4a453a90b52b17c3fa9b6ed6058cd10192a7de4c --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=test --base=ee1d0a649881edb418803f281691b1fbc879e1ec --head=4a453a90b52b17c3fa9b6ed6058cd10192a7de4c --parallel=1
• nx-cloud record -- yarn depcheck
• nx affected --target=lint --base=ee1d0a649881edb418803f281691b1fbc879e1ec --head=4a453a90b52b17c3fa9b6ed6058cd10192a7de4c --parallel=3
• nx affected --target=build --base=ee1d0a649881edb418803f281691b1fbc879e1ec --head=4a453a90b52b17c3fa9b6ed6058cd10192a7de4c --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=ee1d0a649881edb418803f281691b1fbc879e1ec --head=4a453a90b52b17c3fa9b6ed6058cd10192a7de4c
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Oct 21, 2022 at 9:16PM (UTC)

[mandarini]

Hi there @puku0x ! I'm so sorry it's taken forever to look into this, and thank you! I'm looking into this today, I've been a bit short of time in the past couple of weeks, thanks for bearing with me!

[mandarini]

Hi @puku0x ! I was just trying your fix in this repo posted here, and it does not seem to fix the issue... The error I'm getting is here. Is this the issue you were targeting to fix?

[mandarini]

I'll merge this, but please let me know @puku0x if you were trying to fix that issue I linked above. I'm curious as to what's causing it and how it could be fixed, and you seem to have a better idea than me! :)

[puku0x]

@mandarini Thank you for your comment.
This patch is originally supposed to be used with RyanClementsHax/storybook-addon-next#101 (or following workaround).

// apps/next-app/.storybook/main.js
webpackFinal: async (config, { configType }) => {
  // apply any global webpack configs that might have been specified in .storybook/main.js
  if (rootMain.webpackFinal) {
    config = await rootMain.webpackFinal(config, { configType });
  }

  // Workaround for https://github.com/RyanClementsHax/storybook-addon-next/issues/100
  config.module.rules
    .filter((rule) => rule.test && 'test.jpeg'.match(rule.test))
    .forEach((rule) => {
      if (rule.use) {
        rule.use.forEach((use) => {
          if (use.options && !use.options.filename) {
            use.options.filename = 'static/media/[path][name][ext]';
          }
        });
      }

      if (rule.generator && !rule.generator.filename) {
        rule.generator.filename = 'static/media/[path][name][ext]';
      }
    });

  return config;
},

Unfortunately, the PR was closed :(

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.