feat(core): add keepExistingVersions to all packages (#21169)

nrwl · Jan 17, 2024 · 6141f44 · 6141f44 · vercel · Jan 17, 2024
1 parent 544a2c4
commit 6141f44
Show file tree

Hide file tree

Showing 104 changed files with 527 additions and 74 deletions.
diff --git a/docs/generated/packages/angular/generators/init.json b/docs/generated/packages/angular/generators/init.json
@@ -26,6 +26,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "additionalProperties": false,

diff --git a/docs/generated/packages/cypress/generators/init.json b/docs/generated/packages/cypress/generators/init.json
@@ -20,6 +20,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "presets": []

diff --git a/docs/generated/packages/detox/generators/init.json b/docs/generated/packages/detox/generators/init.json
@@ -18,6 +18,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/esbuild/generators/init.json b/docs/generated/packages/esbuild/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/eslint/generators/init.json b/docs/generated/packages/eslint/generators/init.json
@@ -8,7 +8,19 @@
     "title": "Initialize ESLint Plugin",
     "description": "Set up the ESLint plugin.",
     "type": "object",
-    "properties": {},
+    "properties": {
+      "skipPackageJson": {
+        "description": "Do not add dependencies to `package.json`.",
+        "type": "boolean",
+        "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
+      }
+    },
     "required": [],
     "presets": []
   },

diff --git a/docs/generated/packages/expo/generators/init.json b/docs/generated/packages/expo/generators/init.json
@@ -18,6 +18,12 @@
         "type": "boolean",
         "default": false,
         "description": "Do not add dependencies to `package.json`."
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/express/generators/init.json b/docs/generated/packages/express/generators/init.json
@@ -18,6 +18,12 @@
         "type": "boolean",
         "default": false,
         "description": "Do not add dependencies to `package.json`."
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/jest/generators/init.json b/docs/generated/packages/jest/generators/init.json
@@ -20,6 +20,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/js/generators/init.json b/docs/generated/packages/js/generators/init.json
@@ -24,6 +24,12 @@
         "description": "Skip adding package.json dependencies",
         "x-priority": "internal"
       },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
+      },
       "tsConfigName": {
         "type": "string",
         "description": "Customize the generated tsconfig file name.",

diff --git a/docs/generated/packages/nest/generators/init.json b/docs/generated/packages/nest/generators/init.json
@@ -19,6 +19,12 @@
         "type": "boolean",
         "default": false,
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "additionalProperties": false,

diff --git a/docs/generated/packages/next/generators/init.json b/docs/generated/packages/next/generators/init.json
@@ -19,6 +19,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/node/generators/init.json b/docs/generated/packages/node/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/nuxt/generators/init.json b/docs/generated/packages/nuxt/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/playwright/generators/init.json b/docs/generated/packages/playwright/generators/init.json
@@ -19,6 +19,12 @@
         "default": false,
         "description": "Do not add dependencies to `package.json`.",
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/react-native/generators/init.json b/docs/generated/packages/react-native/generators/init.json
@@ -20,6 +20,12 @@
         "type": "boolean",
         "default": false,
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/react/generators/init.json b/docs/generated/packages/react/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/remix/generators/init.json b/docs/generated/packages/remix/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/rollup/generators/init.json b/docs/generated/packages/rollup/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/storybook/generators/init.json b/docs/generated/packages/storybook/generators/init.json
@@ -17,6 +17,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "presets": []

diff --git a/docs/generated/packages/vite/generators/init.json b/docs/generated/packages/vite/generators/init.json
@@ -17,6 +17,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "presets": []

diff --git a/docs/generated/packages/vue/generators/init.json b/docs/generated/packages/vue/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/web/generators/init.json b/docs/generated/packages/web/generators/init.json
@@ -19,6 +19,12 @@
         "type": "boolean",
         "default": false,
         "x-priority": "internal"
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/docs/generated/packages/webpack/generators/init.json b/docs/generated/packages/webpack/generators/init.json
@@ -18,6 +18,12 @@
         "description": "Do not add dependencies to `package.json`.",
         "type": "boolean",
         "default": false
+      },
+      "keepExistingVersions": {
+        "type": "boolean",
+        "x-priority": "internal",
+        "description": "Keep existing dependencies versions",
+        "default": false
       }
     },
     "required": [],

diff --git a/e2e/vite/src/vite-pcv3.test.ts b/e2e/vite/src/vite-pcv3.test.ts
@@ -1,4 +1,12 @@
-import { cleanupProject, newProject, runCLI, uniq } from '@nx/e2e/utils';
+import {
+  cleanupProject,
+  killProcessAndPorts,
+  newProject,
+  runCLI,
+  runCommandUntil,
+  uniq,
+} from '@nx/e2e/utils';
+import { ChildProcess } from 'child_process';
 
 const myApp = uniq('my-app');
 const myVueApp = uniq('my-vue-app');
@@ -46,4 +54,25 @@ describe('@nx/vite/plugin', () => {
       expect(result).toContain('Successfully ran target test');
     }, 200_000);
   });
+
+  it('should run serve-static', async () => {
+    let process: ChildProcess;
+    const port = 8081;
+
+    try {
+      process = await runCommandUntil(
+        `serve-static ${myApp} --port=${port}`,
+        (output) => {
+          return output.includes(`http://localhost:${port}`);
+        }
+      );
+    } catch (err) {
+      console.error(err);
+    }
+
+    // port and process cleanup
+    if (process && process.pid) {
+      await killProcessAndPorts(process.pid, port);
+    }
+  });
 });