feat: Add dtsLiteral to config to write literal types #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declared literal types allow consumers to create more rigid type guards in their projects Co-authored-by: Torgeir Lorange Østby <[email protected]>
ingvilddev
approved these changes
Aug 14, 2024
torgeilo
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared literal types allow consumers to create more rigid type guards in their projects.
Moves the proposed literal types addition proposed in nrkno/core-icons#303 to a feature of svg-to-js and added @torgeilo as co-author.
This change constitutes a minor change to the package.
Note: Made a couple of attempts to use the typescript compiler to verify that the generated .d.ts -strings are valid types within the jest test-rig to no immediate avail, so the changes are tested manually. Would love some input on how we can validate the syntax generated by a library, and not the types of the library itself.