This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
fix(core-suggest): adjust filter case to allow to filter for empty string #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enordby
approved these changes
Oct 26, 2023
christianeide
approved these changes
Oct 26, 2023
…cleared after filtering
klizter
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes built-in filtering of static content in core-suggest
Previously, when clearing the input to empty value
'', this would parse as falsy and no reset/re-filtering would take place. By changing the case toself.input.value != nullwe maintian filtering fornullorundefinedbut allow for filtering using other falsy values like'',0,NaN.Note that being an input, the value will be cast to a string, and so the effective change will only be to allow for filtering by empty string. e.g.
NaNwould actually be'NaN'and as such a perfectly valid string to filter by.Resolves #748