Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Core toggle outside viewport #655

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Conversation

skjalgepalg
Copy link
Collaborator

Reworked autopositioning logic for core-toggle.

  • Check for room in all directions to avoid drawing outside viewport
  • Handle toggled content larger than viewport
  • Default to centering (horizontally) on screen if there is no room to draw fully to either left or right

Resolves #648

Improved docs section to illustrate effects of autoposition

Screenshot 2022-08-24 at 11 36 50
Screenshot 2022-08-24 at 11 36 59
Screenshot 2022-08-24 at 11 37 09
Screenshot 2022-08-24 at 11 37 22
Screenshot 2022-08-24 at 11 37 31
Screenshot 2022-08-24 at 11 37 48

@skjalgepalg skjalgepalg merged commit 82444f7 into master Sep 12, 2022
@skjalgepalg skjalgepalg deleted the core-toggle-outside-viewport branch September 12, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core-toggle is positioned outside viewport on mobile
3 participants