P2P support #25346

rado17 · 2025-10-31T10:02:11Z

No description provided.

NordicBuilder · 2025-10-31T10:02:58Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`cf4e3b8` (`main`)	nrfconnect/sdk-nrfxlib#1902	nrfconnect/sdk-nrfxlib#1902/files
zephyr	nrfconnect/sdk-zephyr@`164b47d`	nrfconnect/sdk-zephyr#3452	nrfconnect/sdk-zephyr#3452/files

⛔ DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-10-31T10:13:23Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 8

Inputs:

Sources:

hal_nordic: PR head: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
sdk-nrf: PR head: 2140d0d639a5886aa1a36662733ea5de0ed04b5c
nrfxlib: PR head: b6ed449969cf72c3a6de18286f00de1e1056cdf6
hostap: PR head: 8de3d62b8b1fdb3257de67ed1784461a4fcf0c21
zephyr: PR head: a1b2c1d5af7a7191247e755c0af367d7e7ade00d

more details

hal_nordic:

PR head: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
merge base: 979a58d0829108b57f10e90b6c3fc35ab6206e4b
Diff

sdk-nrf:

PR head: 2140d0d639a5886aa1a36662733ea5de0ed04b5c
merge base: cedf3cecedb99311978175981a4292069d6284a9
target head (main): cedf3cecedb99311978175981a4292069d6284a9
Diff

nrfxlib:

PR head: b6ed449969cf72c3a6de18286f00de1e1056cdf6
merge base: 664572979dd1a293a19c47e43749b42800be9c18
target head (main): cf4e3b8ea7c05b4a2c9c3039fd0f114c8397cd2f
Diff

hostap:

PR head: 8de3d62b8b1fdb3257de67ed1784461a4fcf0c21
merge base: 5abcff1c0ecff65f0f81e0cc086b7f766e5101bf
target head (main): 6086dea5ee7406e1eede7f2ca6dff1b00b0f04e2
Diff

zephyr:

PR head: a1b2c1d5af7a7191247e755c0af367d7e7ade00d
merge base: c6dbf158a0b8c45beb78aa76412d99f60cd6467f
target head (main): b5cf3eaf422232176fe4eb00201c811647e8aa64
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (43)

doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── wifi
│  │  │  │  ├── index.rst
│  │  │  │  │ wifi_direct.rst
modules
│  ├── hal
│  │  │ nordic
│  ├── lib
│  │  ├── hostap
│  │  │  ├── hostapd
│  │  │  │  ├── hostapd_cli_zephyr.c
│  │  │  │  │ hostapd_cli_zephyr.h
│  │  │  ├── src
│  │  │  │  ├── ap
│  │  │  │  │  │ hostapd.h
│  │  │  │  ├── common
│  │  │  │  │  │ wpa_ctrl.h
│  │  │  │  ├── crypto
│  │  │  │  │  │ tls_mbedtls_alt.c
│  │  │  │  ├── drivers
│  │  │  │  │  ├── driver_zephyr.c
│  │  │  │  │  │ driver_zephyr.h
│  │  │  │  ├── utils
│  │  │  │  │  ├── includes.h
│  │  │  │  │  │ os_zephyr.c
│  │  │  ├── wpa_supplicant
│  │  │  │  ├── wpa_cli.c
│  │  │  │  ├── wpa_cli_cmds.c
│  │  │  │  ├── wpa_cli_zephyr.c
│  │  │  │  ├── wpa_cli_zephyr.h
│  │  │  │  ├── wpa_supplicant.c
│  │  │  │  │ wpa_supplicant_i.h
nrfxlib
│  ├── nrf_wifi
│  │  ├── bin
│  │  │  ├── ncs
│  │  │  │  ├── default
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── offloaded_raw_tx
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── radio_test
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── scan_only
│  │  │  │  │  │ nrf70.bin
│  │  │  │  ├── system_with_raw
│  │  │  │  │  │ nrf70.bin
snippets
│  ├── wifi-p2p
│  │  ├── README.rst
│  │  ├── snippet.yml
│  │  │ wifi-p2p.conf
west.yml
zephyr
│  ├── drivers
│  │  ├── wifi
│  │  │  ├── nrf_wifi
│  │  │  │  ├── inc
│  │  │  │  │  │ wpa_supp_if.h
│  │  │  │  ├── src
│  │  │  │  │  ├── fmac_main.c
│  │  │  │  │  │ wpa_supp_if.c
│  ├── include
│  │  ├── zephyr
│  │  │  ├── net
│  │  │  │  │ wifi_mgmt.h
│  ├── modules
│  │  ├── hostap
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  ├── supp_api.c
│  │  │  │  ├── supp_api.h
│  │  │  │  ├── supp_events.c
│  │  │  │  ├── supp_events.h
│  │  │  │  ├── supp_main.c
│  │  │  │  ├── supp_main.h
│  │  │  │  │ wpa_cli.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── wifi
│  │  │  │  │  ├── wifi_mgmt.c
│  │  │  │  │  │ wifi_shell.c
│  │ west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
❌ Build twister
- sdk-nrf test count: 911
- sdk-zephyr test count: 686
❌ Integration tests
- ❌ test-fw-nrfconnect-chip
- ❌ test-fw-nrfconnect-nfc
- ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ❌ test-fw-nrfconnect-nrf-iot_thingy91
- ❌ test-fw-nrfconnect-rs
- ❌ test-fw-nrfconnect-fem
- ❌ test-fw-nrfconnect-thread-main
- ❌ test-sdk-find-my
- ❌ test-fw-nrfconnect-nrf_lrcs_positioning
- ❌ test-sdk-wifi
- ❌ test-low-level
- ❌ test-sdk-dfu
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud
- ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
- ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning

Disabled integration tests

- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-sdk-audio
- test-sdk-mcuboot
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

krish2718 · 2025-10-31T15:32:00Z

doc/nrf/protocols/wifi/wifi_direct.rst

@@ -0,0 +1,170 @@
+.. _ug_wifi_direct:
+
+Wi-Fi Direct (P2P mode)


this should ideally be an upstream docs as this is not specific to nRF70.

krish2718 · 2025-10-31T15:32:30Z

snippets/wifi-p2p/wifi-p2p.conf

+CONFIG_WIFI_NM_WPA_SUPPLICANT_P2P=y
+CONFIG_WPA_CLI=y
+CONFIG_WIFI_NM_WPA_SUPPLICANT_LOG_LEVEL_INF=y
+CONFIG_LTO=y


add a comment as to why this is needed.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

richabp · 2025-11-03T12:44:06Z

There is no doc build, please check.

richabp

Needs a Changelog entry for both the docs.

doc/nrf/protocols/wifi/wifi_direct.rst

richabp · 2025-11-03T15:43:00Z

snippets/wifi-p2p/README.rst

+Wi-Fi P2P Snippet (wifi-p2p)
+##########################################


Suggested change

Wi-Fi P2P Snippet (wifi-p2p)

##########################################

Wi-Fi P2P Snippet (wifi-p2p)

############################

richabp · 2025-11-03T15:43:30Z

snippets/wifi-p2p/README.rst

+
+Wi-Fi P2P Snippet (wifi-p2p)
+##########################################
+


Please add some description.

richabp · 2025-11-03T15:44:10Z

snippets/wifi-p2p/README.rst

+Overview
+********
+
+This snippet enables Wi-Fi P2P support in supported networking samples.


Is there anything else to add?

Suggested change

This snippet enables Wi-Fi P2P support in supported networking samples.

This snippet enables Wi-Fi P2P support in supported networking samples.

richabp · 2025-11-03T15:44:38Z

snippets/wifi-p2p/README.rst

+Requirements
+************
+
+Hardware support for:


Please add some intro text.

Suggested change

Hardware support for:

Hardware support for:

doc/nrf/protocols/wifi/wifi_direct.rst

nordicjm · 2025-11-05T08:33:55Z

snippets/wifi-p2p/wifi-p2p.conf

+CONFIG_WIFI_NM_WPA_SUPPLICANT_P2P=y
+CONFIG_WPA_CLI=y
+CONFIG_WIFI_NM_WPA_SUPPLICANT_LOG_LEVEL_INF=y
+CONFIG_LTO=y


and why is this needed? Also why is the log level changed?

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2025-11-10T10:25:40Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-25346/nrf/protocols/wifi/index.html
https://ncsdoc.z6.web.core.windows.net/PR-25346/nrf/protocols/wifi/wifi_direct.html

doc/nrf/protocols/wifi/wifi_direct.rst

Pull Wi-Fi P2P support. Signed-off-by: Ravi Dondaputi <[email protected]>

Pull in changes done to support WPS connection and allowing probe request to be sent to supplicant. Signed-off-by: Ravi Dondaputi <[email protected]>

Create snippet for P2P build. Signed-off-by: Ravi Dondaputi <[email protected]>

Add Wi-Fi direct (p2p mode) document. Signed-off-by: Kapil Bhatt <[email protected]>

richabp · 2025-11-12T10:49:32Z

doc/nrf/protocols/wifi/wifi_direct.rst

+
+   wpa_cli p2p_connect D2:39:FA:43:23:C1 pin go_intent=0
+
+The command outputs a PIN (for example, ``88282282``), which must should be entered on the peer device to complete the connection.


Suggested change

The command outputs a PIN (for example, ``88282282``), which must should be entered on the peer device to complete the connection.

The command outputs a PIN (for example, ``88282282``), which must be entered on the peer device to complete the connection.

richabp · 2025-11-12T10:50:23Z

doc/nrf/protocols/wifi/wifi_direct.rst

+* ``<pbc|pin>`` - WPS provisioning method:
+
+  * ``pin`` - Uses PIN-based WPS authentication.
+    The command returns a PIN (for example, ``88282282``) that must be entered on the peer device.


Suggested change

The command returns a PIN (for example, ``88282282``) that must be entered on the peer device.

The command returns a PIN (for example, ``88282282``), which must be entered on the peer device.

richabp · 2025-11-12T11:19:39Z

doc/nrf/protocols/wifi/wifi_direct.rst

+
+   wifi p2p connect D2:39:FA:43:23:C1 pin -g 0
+
+**``wpa_cli`` command:**


Suggested change

**``wpa_cli`` command:**

``wpa_cli`` command:

richabp · 2025-11-12T11:19:49Z

doc/nrf/protocols/wifi/wifi_direct.rst

+
+Example connection using the PIN method:
+
+**Wi-Fi shell command:**


Suggested change

**Wi-Fi shell command:**

Wi-Fi shell command:

rado17 requested review from a team as code owners October 31, 2025 10:02

NordicBuilder added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 31, 2025

NordicBuilder added manifest-zephyr manifest-nrfxlib DNM labels Oct 31, 2025

rado17 requested review from krish2718 and sachinthegreen October 31, 2025 11:34

sachinthegreen approved these changes Oct 31, 2025

View reviewed changes

rado17 requested a review from krga2022 October 31, 2025 12:46

kapbh requested a review from a team as a code owner October 31, 2025 12:52

kapbh force-pushed the p2p_support branch 2 times, most recently from 3ca0910 to d2098af Compare October 31, 2025 12:57

krish2718 mentioned this pull request Oct 31, 2025

manifest: sdk-nrfxlib: ncs: nrf_wifi: Update RPU patch to rev#4e1fb1bc47b #25336

Closed

krish2718 reviewed Oct 31, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 3, 2025 09:36

kapbh force-pushed the p2p_support branch from d2098af to ff52ed8 Compare November 3, 2025 09:36

Copilot AI reviewed Nov 3, 2025

View reviewed changes

kapbh force-pushed the p2p_support branch from ff52ed8 to 688490a Compare November 3, 2025 10:31

richabp requested changes Nov 3, 2025

View reviewed changes

rado17 requested a review from divyagona November 4, 2025 12:27

richabp requested changes Nov 4, 2025

View reviewed changes

doc/nrf/protocols/wifi/wifi_direct.rst Outdated Show resolved Hide resolved

nordicjm reviewed Nov 5, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 10, 2025 09:47

kapbh force-pushed the p2p_support branch from 688490a to ac07d9f Compare November 10, 2025 09:47

Copilot AI reviewed Nov 10, 2025

View reviewed changes

richabp requested changes Nov 11, 2025

View reviewed changes

rado17 and others added 4 commits November 12, 2025 06:52

manifest: sdk-zephyr: Pull Wi-Fi P2P support

3a4c8e2

Pull Wi-Fi P2P support. Signed-off-by: Ravi Dondaputi <[email protected]>

manifest: sdk-nrfxlib: Update firmware patch blobs

62eeca0

Pull in changes done to support WPS connection and allowing probe request to be sent to supplicant. Signed-off-by: Ravi Dondaputi <[email protected]>

snippets: Add snippet for P2P build options

e512c3a

Create snippet for P2P build. Signed-off-by: Ravi Dondaputi <[email protected]>

doc: wifi: Add Wi-Fi direct document

2140d0d

Add Wi-Fi direct (p2p mode) document. Signed-off-by: Kapil Bhatt <[email protected]>

kapbh force-pushed the p2p_support branch from ac07d9f to 2140d0d Compare November 12, 2025 06:53

richabp requested changes Nov 12, 2025

View reviewed changes

		Wi-Fi P2P Snippet (wifi-p2p)
		##########################################

	This snippet enables Wi-Fi P2P support in supported networking samples.
	This snippet enables Wi-Fi P2P support in supported networking samples.


		wpa_cli p2p_connect D2:39:FA:43:23:C1 pin go_intent=0

		The command outputs a PIN (for example, ``88282282``), which must should be entered on the peer device to complete the connection.

	The command returns a PIN (for example, ``88282282``) that must be entered on the peer device.
	The command returns a PIN (for example, ``88282282``), which must be entered on the peer device.


		wifi p2p connect D2:39:FA:43:23:C1 pin -g 0

		``wpa_cli`` command:


		Example connection using the PIN method:

		Wi-Fi shell command:

P2P support #25346

Are you sure you want to change the base?

P2P support #25346

Uh oh!

Conversation

rado17 commented Oct 31, 2025

Uh oh!

NordicBuilder commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

richabp commented Nov 3, 2025

Uh oh!

richabp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

NordicBuilder commented Oct 31, 2025 •

edited

Loading

NordicBuilder commented Oct 31, 2025 •

edited

Loading