Allow building NCS BM samples without SW ISR table #427
Conversation
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR here. |
There was a problem hiding this comment.
@bjarki-andreasen Please see build issues and rebase on main to update defconfig for SoftDevice S145 board variants.
lib/bm_buttons/bm_buttons.c
Outdated
| #endif | ||
| } | ||
|
|
||
| #if defined(CONFIG_SOC_SERIES_NRF52X) |
There was a problem hiding this comment.
All nRF52 related code can be removed, this was used for early development but will be removed.
manifest update Signed-off-by: Bjarki Arge Andreasen <[email protected]>
The software ISR table is not required if multithreading is not used, and no argument is passed to the irq handlers. Update all drivers, samples and subsystems to not use the SW ISR table and exclude it from the build. This saves approximately 2K ROM for all builds. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
no-sw-isr-table
branch
from
db157bd to
7572386
Compare
| CONFIG_ZERO_LATENCY_IRQS=y | ||
|
|
||
| # Disable generation of the redundant SW ISR table | ||
| CONFIG_GEN_SW_ISR_TABLE=n |
There was a problem hiding this comment.
@bjarki-andreasen This should be added to S145 board variants as well.
|
Please add changelog entry. Otherwise LGTM when manifest is updated and comment above is addressed. |
3 participants
Allow building NCS BM samples without SW ISR table