-
Notifications
You must be signed in to change notification settings - Fork 25
sysbuild: Pass SoftDevice Kconfig selection over #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the documentation preview for this PR here. |
9fcb487 to
57d5b68
Compare
tejlmand
approved these changes
Sep 8, 2025
lemrey
approved these changes
Sep 8, 2025
Contributor
|
@nordicjm Should this have a changelog entry? |
Now selects the SoftDevice Kconfig for all board targets rather than just the MCUboot board variants Signed-off-by: Jamie McCrae <[email protected]>
Selects the Kconfig in target images indicating what SoftDevice is selected Signed-off-by: Jamie McCrae <[email protected]>
Adds a note that boards must now set this Signed-off-by: Jamie McCrae <[email protected]>
57d5b68 to
ca63d53
Compare
Contributor
Author
Added |
eivindj-nordic
approved these changes
Sep 16, 2025
b-gent
approved these changes
Sep 16, 2025
| ====== | ||
|
|
||
| No changes since the latest nRF Connect SDK Bare Metal release. | ||
| * Boards must now select a SoftDevice sysbuild Kconfig in the `Kconfig.sysbuild` file e.g. :kconfig:option:`SB_CONFIG_SOFTDEVICE_S115`. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| * Boards must now select a SoftDevice sysbuild Kconfig in the `Kconfig.sysbuild` file e.g. :kconfig:option:`SB_CONFIG_SOFTDEVICE_S115`. | |
| * Boards must now select a SoftDevice sysbuild Kconfig in the :file:`Kconfig.sysbuild` file, for example :kconfig:option:`SB_CONFIG_SOFTDEVICE_S115`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
doc-postponed
PR requires documentation updates, tech writer review happens later.
doc-required
PR must not be merged without tech writer approval.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.