Test against cherry-pick PR #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Kconfig options for CMUX buffer sizes have changed. Try to align to 4 x CMUX packet size as default buffer. Signed-off-by: Seppo Takalo <[email protected]>
Test against nrfconnect/sdk-nrf#25308 Signed-off-by: Seppo Takalo <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR tests against a cherry-pick PR that brings upstream changes for modem CMUX configuration. The changes update buffer size configuration from a compile-time constant to a more flexible approach.
- Updates west.yml to point to a specific PR for testing
- Replaces hardcoded CONFIG_MODEM_CMUX_WORK_BUFFER_SIZE with the new MODEM_CMUX_WORK_BUFFER_SIZE constant
- Updates overlay configuration to use the new CONFIG_MODEM_CMUX_WORK_BUFFER_SIZE_EXTRA setting and adjusts UART buffer sizes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| west.yml | Points to PR branch for testing upstream changes |
| app/src/sm_cmux.c | Updates buffer declarations to use new constant instead of config macro |
| app/overlay-ppp-cmux-linux.conf | Updates CMUX configuration to use new extra buffer size setting and adjusts UART buffer sizes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MarkusLassila
approved these changes
Oct 30, 2025
When there is no reading end on DLCI pipe, drop URC messages. Signed-off-by: Seppo Takalo <[email protected]>
If the "AT" "OK" sequence fails on the start up script, it might be that the modem is already in CMUX mode. Try recovering the CMUX pipe by sending flag characters followed by CMUX Close Down message. The CMUX is then re-established by SABM message normally. Signed-off-by: Seppo Takalo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test against nrfconnect/sdk-nrf#25308
That brings upstream PR changes: nrfconnect/sdk-zephyr#3444