Skip to content

Make commands optional #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 2 commits into from
Nov 17, 2017
Merged

Make commands optional #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e79f6
Make commands optional
ycombinator Nov 17, 2017
2cbb06c
Adding back prop type for commands, sans isRequired
ycombinator Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/core_plugins/kibana/public/home/components/tutorial/instruction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,13 @@ export function Instruction({ commands, paramValues, textPost, textPre }) {
post = <Content className="kuiVerticalRhythm" text={textPost}/>;
}

const aceOptions = {
fontSize: '14px',
maxLines: commands.length
};

return (
<div className="instruction">

{pre}

let commandsMarkup;
if (commands) {
const aceOptions = {
fontSize: '14px',
maxLines: commands.length
};
commandsMarkup = (
<div className="kuiVerticalRhythm">
<KuiCodeEditor
mode="sh"
Expand All @@ -39,15 +36,22 @@ export function Instruction({ commands, paramValues, textPost, textPre }) {
isReadOnly
/>
</div>
);
}

return (
<div className="instruction">

{pre}
{commandsMarkup}
{post}

</div>
);
}

Instruction.propTypes = {
commands: PropTypes.array.isRequired,
Copy link
Copy Markdown
Owner

@nreese nreese Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should stay but just remove the .isRequired

commands: PropTypes.array,
paramValues: PropTypes.object.isRequired,
textPost: PropTypes.string,
textPre: PropTypes.string,
Expand Down