Skip to content

Refactor: extract common LS instructions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 1 commit into from
Nov 17, 2017
Merged

Refactor: extract common LS instructions #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/core_plugins/kibana/common/tutorials/logstash_instructions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
export const LOGSTASH_INSTRUCTIONS = {
INSTALL: {
OSX: {
title: 'Download and install Logstash',
textPre: 'Skip this step if Logstash is already installed. First time using Logstash? See the ' +
'[Getting Started Guide]({config.elastic_docs.website_url}/guide/en/logstash/{config.elastic_docs.link_version}' +
'/getting-started-with-logstash.html).',
commands: [
'curl -L -O https://artifacts.elastic.co/downloads/logstash/logstash-{config.kibana.version}.tar.gz',
'tar xzvf logstash-{config.kibana.version}.tar.gz'
]
}
}
};
12 changes: 2 additions & 10 deletions src/core_plugins/kibana/server/tutorials/netflow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { PARAM_TYPES } from '../../../common/tutorials/param_types';
import { TUTORIAL_CATEGORY } from '../../../common/tutorials/tutorial_category';
import { INSTRUCTION_VARIANT } from '../../../common/tutorials/instruction_variant';
import { LOGSTASH_INSTRUCTIONS } from '../../../common/tutorials/logstash_instructions';

export function netflowSpecProvider() {
return {
Expand Down Expand Up @@ -31,16 +32,7 @@ export function netflowSpecProvider() {
{
id: INSTRUCTION_VARIANT.OSX,
instructions: [
{
title: 'Download and install Logstash',
textPre: 'Skip this step if Logstash is already installed. First time using Logstash? See the ' +
'[Getting Started Guide]({config.elastic_docs.website_url}/guide/en/logstash/{config.elastic_docs.link_version}' +
'/getting-started-with-logstash.html).',
commands: [
'curl -L -O https://artifacts.elastic.co/downloads/logstash/logstash-{config.kibana.version}.tar.gz',
'tar xzvf logstash-{config.kibana.version}.tar.gz'
]
},
LOGSTASH_INSTRUCTIONS.INSTALL.OSX,
{
title: 'Set up the Netflow module',
textPre: 'In the Logstash install directory, run the following command to set up the Netflow module.',
Expand Down